I'm not quite sure what to do with this one as I feel like adding another popup prompt for every attack adds a lot of unnecessary friction for the user. Sometimes you may also want to cancel your attack when you realize your creature no longer has a ShieldBreakModifier you expected it to have and that's no longer possible in this PR.

Maybe it's possible to fix these cards that shows shields before selection in another way, like adding some flag to the AttackPlayer event that says it can't be cancelled, then we could add these extra popups and confirmation logic to the specific cards that shows shields, and once the player selects to see the shields it can mark the next AttackPlayer attack as not cancellable. Would that work?

It is implemented the way it is out of a matter of accuracy. On the matter of cancelling the attack, it's really up to the player to be careful when attacking. The ruling should be prioritized.

is this PR still up-to-date? some cards in it are already implemented or have different implementations